Reply to Editor in the Onion Console -- left full of debugging code! on Fri, 02 Feb 2018 14:25:03 GMT

Silvia — Fri, 02 Feb 2018 14:25:03 GMT

Hi,

I'm using the Editor in the Onion Console to write some code, and sometimes it's handy to have the console in the developer tools (F12 in Chrome) open while writing Javascript, as I can quickly check some of the commands etc.

The developers have left TONS of debugging code, making the browser console almost useless. Extract below:

The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 17 onion-file-provider.html?r=a2:435 The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 18 onion-file-provider.html?r=a2:435 The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 19 onion-file-provider.html?r=a2:435 The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 20 onion-file-provider.html?r=a2:435 The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 21 onion-file-provider.html?r=a2:435 The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 22 onion-file-provider.html?r=a2:435 The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 23 onion-file-provider.html?r=a2:435 The saveContentHandler is running onion-file-provider.html?r=a2:436 Object onion-file-provider.html?r=a2:437 24 onion-file-provider.html?r=a2:451 Inside the last iteration callback,should be called 6onion-session-provider.html?r=a2:116 Alive onion-file-list.html:130 MouseEvent onion-editor.html?r=a2:240 fileEventClick Object onion-editor.html?r=a2:363 isFileInArray gets called onion-editor.html?r=a2:367 Array(3) onion-editor.html?r=a2:384 false onion-editor.html?r=a2:263 Is file opened?,: false onion-editor.html?r=a2:275 files is not in Array, It needs to be added onion-editor.html?r=a2:291 addfileToArray gets called, fileObj is: Object onion-file-provider.html?r=a2:26 /MMG2/GW/msgToServer.json5 onion-file-provider.html?r=a2:271 Object onion-file-provider.html?r=a2:374 Should return fileContent onion-editor.html?r=a2:293 [] onion-editor.html?r=a2:445 msgToServer.json5 onion-editor.html?r=a2:447 json5 onion-editor.html?r=a2:299 Inside callback of isFileNameSame, isSame false onion-editor.html?r=a2:997 openFilesObserver gets called onion-editor.html?r=a2:998 4 onion-editor.html?r=a2:1004 ShowFileButtons onion-editor.html?r=a2:279 3 onion-editor.html?r=a2:187 showClose Gets Called onion-editor.html?r=a2:188 index 0 onion-editor.html?r=a2:189 currTab 3 onion-editor.html?r=a2:187 showClose Gets Called onion-editor.html?r=a2:188 index 1 onion-editor.html?r=a2:189 currTab 3 onion-editor.html?r=a2:187 showClose Gets Called onion-editor.html?r=a2:188 index 2 onion-editor.html?r=a2:189 currTab 3 bootstrap-pill.html:51 opaque false bootstrap-pill.html:53 nav-link onion-editor.html?r=a2:958 3 onion-editor.html?r=a2:959 Inside currentTabChange onion-editor.html?r=a2:960 this.currentTab 3 onion-editor.html?r=a2:961 this.fileIndex 2 onion-editor.html?r=a2:985 Current Tab observer has been called onion-editor.html?r=a2:986 currentTab 3 onion-editor.html?r=a2:987 fileIndex 2 onion-editor.html?r=a2:943 INSIDE THE saveUpdate Function onion-editor.html?r=a2:946 The codes are the same and do not need to be saved onion-editor.html?r=a2:420 The File Index is 3 onion-editor.html?r=a2:421 … onion-editor.html?r=a2:281 3 onion-editor.html?r=a2:282 3 bootstrap-pill.html:51 opaque false bootstrap-pill.html:53 nav-link onion-editor.html?r=a2:187 showClose Gets Called onion-editor.html?r=a2:188 index 3 onion-editor.html?r=a2:189 currTab 3 bootstrap-pill.html:51 opaque false bootstrap-pill.html:53 nav-link active onion-editor.html?r=a2:428 Index 3 onion-editor.html?r=a2:429 Element Object onion-editor.html?r=a2:555 ƒ (response){ if(response.status == 'failure'){ //DoNothing, if save fails return; }else if(response.status == 'success' || response =="SaveNotNecessary" || response =="ChoseNotTo… onion-editor.html?r=a2:943 INSIDE THE saveUpdate Function onion-editor.html?r=a2:946 The codes are the same and do not need to be saved onion-editor.html?r=a2:510 Length of openFilesArray before splice 4 onion-editor.html?r=a2:997 openFilesObserver gets called onion-editor.html?r=a2:998 3 onion-editor.html?r=a2:1004 ShowFileButtons onion-editor.html?r=a2:512 Length of openFilesArray after splice 3 onion-editor.html?r=a2:534 openFiles length is > 0 onion-editor.html?r=a2:541 currentTab does not equal new currentTab onion-editor.html?r=a2:187 showClose Gets Called onion-editor.html?r=a2:188 index 0 onion-editor.html?r=a2:189 currTab 2 onion-editor.html?r=a2:187 showClose Gets Called onion-editor.html?r=a2:188 index 1 onion-editor.html?r=a2:189 currTab 2 onion-editor.html?r=a2:187 showClose Gets Called onion-editor.html?r=a2:188 index 2 onion-editor.html?r=a2:189 currTab 2 onion-editor.html?r=a2:187 showClose Gets Called

Etc. I'm sure you get the idea.

I'd suggest removing all of these for the next upgrade.

Thanks.

Reply to Editor in the Onion Console -- left full of debugging code! on Sat, 03 Feb 2018 14:53:24 GMT

Zheng Han — Sat, 03 Feb 2018 14:53:24 GMT

@Silvia thanks for the suggestion.

Reply to Editor in the Onion Console -- left full of debugging code! on Sun, 04 Feb 2018 12:44:01 GMT

György Farkas — Sun, 04 Feb 2018 12:44:01 GMT

There will be an upgraded Omega2(+) firmware release and/or a bug free official web-based Onion Console someday ...
@Silvia you are too optimistic

Reply to Editor in the Onion Console -- left full of debugging code! on Mon, 05 Feb 2018 12:40:10 GMT

Silvia — Mon, 05 Feb 2018 12:40:10 GMT

@György-Farkas said in Editor in the Onion Console -- left full of debugging code!:

There will be an upgraded Omega2(+) firmware release and/or a bug free official web-based Onion Console someday ...
@Silvia you are too optimistic

Oh well, I had to at least try!